Closed joseraulgonzalez closed 7 years ago
Agreed. Including Compat.jl is a good idea going forward. Let's get a patch ready to handle v0.6 soon.
I see that compatibility with v0.6 has been fixed. Thank you!
No problem. Note that I looked into using Compat for backwards compatibility, but dropped it due to issues with changing how inner constructors behaved.
The following lists some changes from v0.6 onwards that affect QuantumBayesian.jl: https://github.com/JuliaLang/julia/blob/v0.6.0/NEWS.md
In particular, note the following changes
These changes cause a laundry list of warnings in the CI testing, as well as an error related to subtyping.
To move forward, maybe Compat.jl can be added to the list of requirements of the package and code for different version targets can be stored in different branches of the repo.
Thoughts?