justindujardin / pathy

simple, flexible, offline capable, cloud storage with a Python path-like interface
Apache License 2.0
171 stars 23 forks source link

Issue-107: Check bucket exists on is_dir #108

Closed yaelmi3 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7bd2080) 100.00% compared to head (264b206) 79.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #108 +/- ## ============================================ - Coverage 100.00% 79.03% -20.97% ============================================ Files 6 6 Lines 1159 1159 ============================================ - Hits 1159 916 -243 - Misses 0 243 +243 ``` | [Files](https://app.codecov.io/gh/justindujardin/pathy/pull/108?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Justin+DuJardin) | Coverage Δ | | |---|---|---| | [pathy/\_\_init\_\_.py](https://app.codecov.io/gh/justindujardin/pathy/pull/108?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Justin+DuJardin#diff-cGF0aHkvX19pbml0X18ucHk=) | `98.68% <100.00%> (-1.32%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/justindujardin/pathy/pull/108/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Justin+DuJardin)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

justindujardin commented 1 year ago

I don't have a good solution for running the tests from a fork because of my secrets. The local adapter tests pass, and the code looks good, so I'll merge this without triggering the auto-release until the build passes. Thanks for the fix!

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 0.10.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: