Open yaelmi3 opened 1 year ago
@yaelmi3 thanks for providing this review/analysis! 🙇
Could you construct a performance test that measures how slow it is and compare it with your suggested change? I can run it on all the cloud providers to get a sense of the impact if you write a script that works with the local-mode implementation.
env: python3.10, tested with GS
Consider the following case:
In this case we check whether the exact blob exists , but in case it doesn't exist, we continue to checking partial blob appearance, in all bucket files using
startswith
. This introduces 2 possible issues:exists
will returnTrue
, but it might not be the blob we are referring toPossible solutions
exists
, something likeexact_match