refactor: construct bucket paths with scheme prefixes

justindujardin / pathy

simple, flexible, offline capable, cloud storage with a Python path-like interface

Apache License 2.0

171 stars 23 forks source link

refactor: construct bucket paths with scheme prefixes #18

Closed justindujardin closed 4 years ago

justindujardin commented 4 years ago

BREAKING CHANGES: GCSPaths must include a path scheme

Before GCSPath would convert /bucket-name/file into gs://bucket-name/file internally. This leads to ambiguity *(thanks @honnibal) when dealing with regular file-system paths and bucket paths together. Does the path /foo/bar point to an absolute file path or a GCS bucket named foo?

Now paths must be constructed with a path scheme. This allows GCSPath to deal with both types of paths, and is needed for the CLI app/s to come.

justindujardin commented 4 years ago

:tada: This PR is included in version 0.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: