justindujardin commented 4 years ago

If about.py changes and we don't test it, codecov.io is all like "wah, you didn't hit your diff targets because you went from 0% to 0% on about.py" :sweat_smile:

Changes

[x] Add test that verifies about.version is set
[x] Consolidate some tests into test_base.py to match the source file names

codecov[bot] commented 4 years ago

Codecov Report

Merging #32 into master will increase coverage by 0.80%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   79.47%   80.27%   +0.80%     
==========================================
  Files           7        7              
  Lines         872      872              
==========================================
+ Hits          693      700       +7     
+ Misses        179      172       -7

Impacted Files	Coverage Δ
pathy/about.py	`100.00% <0.00%> (+100.00%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4828045...2453f06. Read the comment docs.

justindujardin commented 3 years ago

:tada: This PR is included in version 0.3.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

justindujardin / pathy

Fix issue where release commits failed code cov check #32

Codecov Report