search

justinethier / cyclone

:cyclone: A brand-new compiler that allows practical application development using R7RS Scheme. We provide modern features and a stable system capable of generating fast native binaries.
http://justinethier.github.io/cyclone/
MIT License
823 stars 42 forks source link

`assv` seems implemented as `assq` #490

Closed okuoku closed 2 years ago

okuoku commented 2 years ago

Tested: https://github.com/justinethier/cyclone/tree/cf66cf1057fcd687cc42d4d7dcaeeef00cba089b

It seems assv implemented as assq.

cyclone> (define a 0.0)
ok
cyclone> (assoc a (list (list a)))
(0.0)
cyclone> (assoc 0.0 (list (list a)))
(0.0)
cyclone> (assv a (list (list a)))
(0.0)
cyclone> (assv 0.0 (list (list a)))
#f

Did you mean assv here? https://github.com/justinethier/cyclone/blob/6ffd229dcdd1b74e77bc3f33d245efc4c340edf6/runtime.c#L5395

(and maybe memvp here https://github.com/justinethier/cyclone/blob/6ffd229dcdd1b74e77bc3f33d245efc4c340edf6/runtime.c#L5409 )

xref: #375

justinethier commented 2 years ago

Good catch, let me take a look.

justinethier commented 2 years ago

Thanks for the report @okuoku. This is now fixed on our primary branch in GitHub.