search

justinfagnani / route

A client + server routing library for Dart
BSD 3-Clause "New" or "Revised" License
114 stars 40 forks source link

The router incorrectly registers top level click listener and then prevents default on all routes. #69

Closed mhevery closed 10 years ago

mhevery commented 10 years ago

See: https://github.com/dart-lang/route/blob/experimental_hierarchical/lib/client.dart#L605

1) The click events should never be preventDefault() because it breaks command-click open link in new tap in browser

2) The click listener should be on the root of the app not on window. The app can be a subset of the current view, and we should not be intercepting clicks which do not belong to our app.

pavelgj commented 10 years ago

Fixed in

and in angular