justinhunt / moodle-assign_submission_onlinepoodll

The PoodLL assignment submission plugin for Moodle 2.3 and above
0 stars 5 forks source link

Poodll Submissions in Safari #6

Open lfhawasli opened 3 years ago

lfhawasli commented 3 years ago

Online Poodll submissions Release 3.1.7 (Build 2021022800)

We are encountering an issue in safari with the latest release.

Tested on Safari Version 14.0.3 (15610.4.3.1.6, 15610) macOS Catalina Version 10.15.7 (19H512)

justinhunt commented 3 years ago

Thanks for the report Lillian. There are a few factors that depend on your settings. Can we check those? i) What is the recorder skin? ii) Is the site set up to convert media to mp3/mp4 properly

Can you send me your support info file csv? That can be exported from: Site administration -> plugins -> filters -> Poodll -> Support Info

Since that contains info about your site that you might not want public, can you send it the form at: via https://poodll.com/contact

justinhunt commented 3 years ago

NB the support info file contains the skin and other settings. So that should answer all the questions.

rlorenzo commented 3 years ago

@justinhunt Submitted support CSV at https://poodll.com/contact/

justinhunt commented 3 years ago

Thanks Rex. I could confirm the safari issue. The MediaRecorder on Safari does not support the "pause" method it seems. Will disable it on Safari (or any platform that does not support it).

The playback issue is a bit odd. I can't confirm your report exactly, because all media recorded by Safari or Chrome in the OnlinePoodll Assignment Submission appears to not playback correctly in Safari. This is due to a CORS issue. Something has changed in Safari I think, crossorigin="anonymous" attribute seems to be killing it. Though this works well on other browsers. Set to "anonymous" when dealing with the same origin should send cookies through, and authenticate the user in the call to pluginfile.php. But Safari might just be not sending cookies regardless of origin. I will revisit this and see what I can come up with

justinhunt commented 3 years ago

Hi Lillian and Rex, I updated a version now of the online poodll assignment submission type which fixes the playback issue on Safari.

The pause issue is more tricky. The pause method does exist in Safari MediaRecorder, but calling it has no effect and throws an error in the console. This means we can not use feature detection to determine whether to hide / show the pause button. It means we have to hide it on Safari. If it is not critical, perhaps you could choose the 123 recorder skin which has no pause option, in place of the "plain" skin that you use currently.

You can set the skins in the Poodll filter admin settings, and also on the Poodll filter course and activity settings.

lfhawasli commented 3 years ago

Hi Justin,

Our team tested out the playback, and the issue still persists for us

Tested on

justinhunt commented 3 years ago

Hi Lillian. I am not able to confirm this. When you test at: https://demo.poodll.com/mod/assign/view.php?id=87

Are you able to record and playback?