Suggestion: remove db/access.php from the template

[mudrd8mz]

This is a feedback based on experience from approval reviews in the Moodle Plugins directory. It seems that (some) folks tend to keep the db/access.php just because the template has it. There are often no benefits of it.

No standard Atto plugin has the file. In fact, for most (almost all) Atto plugins, checking for availability/visibility permissions does not seem to make sense. Additionally, as there is no default permission for the "user" archetype in the template, the Atto plugin may not be available in places like own profile editing.

My suggestion is

• either to remove the capability stuff from the template completely. In rare cases when it is needed, the developer should be well aware of how to add it manually;
• or at least fix the template so that the contextlevel is set to the system context and the only archetype used is the Authenticated user (but again, the actual use case for such thing is really rare imho).

[justinhunt]

Sure. This seems fair enough. In the initial plugins I made from this we were adding content to the html area that we might not want students to be able to add. But you are right, thats probably not normal, and the issue of the contextlevel remains. I will remove access.php and related code shortly.