search

justinhunt / moodle-filter_generico

Generic Filter
9 stars 11 forks source link

Feature Request: Apply moodle permission #26

Open simonbbrown opened 3 years ago

simonbbrown commented 3 years ago

Hi Team!

We use this plugin, but have some pretty strict rules around role allocation in our Moodle platforms. At the moment only our Site Administrators have the ability to manage Genrico filters, it would be great if we could assign permissions to allow other users to also manage the Generico filters, e.g. the System manager role.

Thanks!

justinhunt commented 3 years ago

Thanks Simon. I definitely see the issue. I had a go at this and created "filter/generico:managetemplates" but though it fails to load the settings page because it is nested in the plugins -> filters menu for which the user does not have permission. Well at least thats how it seems. Perhaps that can be overcome somehow? The other way would be to put the settings elsewhere in the site admin tree.

simonbbrown commented 3 years ago

Hi Justin, I'd be happy to have one of my guys take a look and see if they can work it out. What branch are you using?

justinhunt commented 3 years ago

Thanks that would be great. Its all in the master branch. The capability was added in the last commit. https://github.com/justinhunt/moodle-filter_generico/commit/5f72280f6bde18aeb7212739b9fa790c299af403

If it turns out to be really hard we might fudge on it. Because the template settings really are due for a complete makeover. We want to store the templates in a DB table with a CRUD interface. That will make it possible to have personal ones, and course level ones etc.