search

justinhunt / moodle-filter_poodll

The PoodLL Filter
6 stars 17 forks source link

Problem with Essential theme #1

Open oertel opened 9 years ago

oertel commented 9 years ago

Hi Justin,

the widely used Essential theme for Moodle uses in the current version an option to enable/disable FitVids - default it is enabled.

The Essential description: Enable FitVids (fitvidsjs.com) to make your embedded videos responsive. If FitVids is on and you want a video to be excluded then add 'class="fitvidsignore"' to the 'iframe' tag in the HTML mode of the editor. For example: ''.

If FitVids is enabled, there are some problems with the PoodLL recorder - see old bug report. The recorder has an unusual size and overlaps sometimes important Moodle elements (e.g. if you grading PoodLL submissions). The old bug report describes a solution for that:

If embedded flash objects still have the issue (say as a part of a label) then add the 'fitvidsignore ' class to the container (use HTML mode in the editor) -> https://github.com/davatron5000/FitVids.js.

I could disable FitVids in the theme settings, but it provides responive design functionality for other video players. So it would be easier if you add the class="fitvidsignore" to the surrounding flash container in the filter code.

Thanks, Stefan

justinhunt commented 9 years ago

I added fitvidsignore a few days ago. I tried to test it myself, but couldn't really tell if it was working or not. Could you pull the latest changes and tell me if it has fixed anything?

I added the fitvidsignore class to the table cell that all the flash widgets are loaded in, and to the iframe that they are loaded in, in some places. There probably is no real need to load the widgets in a single cell table, it was something I did a long time ago and never changed. So if it is necessary to use a div we can do that.

oertel commented 9 years ago

Hi Justin, thanks a lot.

I have checked with Moodle 2.7.3+ (Build: 20141120) and filter_poodll 2.7.3(Build 2014111601).

The situation is the same as before:

bild1

If I disable the option "Use FitVids" in the general settings of Essential everything is fine, but the responsive style of embedded videos is gone:

bild3

justinhunt commented 9 years ago

OK. Let me try the same test and see what I can come up with.

Thanks

On Mon, Nov 24, 2014 at 5:41 PM, oertel notifications@github.com wrote:

Hi Justin, thanks a lot.

I have checked with Moodle 2.7.3+ (Build: 20141120) and _filterpoodll 2.7.3(Build 2014111601 <2014111601>).

The situation is the same as before:

[image: bild1] https://cloud.githubusercontent.com/assets/6482225/5162191/dcdc6ac6-73bb-11e4-9964-8449d0730d2d.JPG

If I disable the option "Use FitVids" in the general settings of Essential everything is fine, but the responsive style of embedded videos is gone:

[image: bild3] https://cloud.githubusercontent.com/assets/6482225/5162317/04c4949e-73be-11e4-8759-03f8b9ccac4a.JPG

— Reply to this email directly or view it on GitHub https://github.com/justinhunt/moodle-filter_poodll/issues/1#issuecomment-64164767 .