search

justinhunt / moodle-filter_poodll

The PoodLL Filter
6 stars 17 forks source link

Unable to use DrawingBoard - JS Errors (Poodll 3) #18

Closed nadavkav closed 7 years ago

nadavkav commented 7 years ago

image

nadavkav commented 7 years ago

drawingboard.min.js:1 Uncaught ReferenceError: $ is not definedDrawingBoard.Control.extend @ drawingboard.min.js:1(anonymous function) @ drawingboard.min.js:1 content.min.js:1 XHR finished loading: GET "chrome-extension://mgijmajocgfcbeboacabfgobmjgjcoja/content.min.css".u @ content.min.js:1y @ content.min.js:1(anonymous function) @ content.min.js:18(anonymous function) @ content.min.js:18 drawingboard.min.js:1 Uncaught TypeError: Cannot read property 'extend' of undefinedDrawingBoard.Board @ drawingboard.min.js:1loaddrawingboard @ module.js:1(anonymous function) @ preview.php?id=273452&courseid=126:245_notify @ yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js&rollup/1475689545/mcore-min.js:9T @ yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js&rollup/1475689545/mcore-min.js:9_finish @ yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js&rollup/1475689545/mcore-min.js:16_onSuccess @ yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js&rollup/1475689545/mcore-min.js:16p @ yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js&rollup/1475689545/mcore-min.js:17onSuccess @ yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js&rollup/1475689545/mcore-min.js:17_finish @ yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js&rollup/1475689545/mcore-min.js:12_next @ yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js&rollup/1475689545/mcore-min.js:12_progress @ yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js&rollup/1475689545/mcore-min.js:13h @ yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js&rollup/1475689545/mcore-min.js:12

nadavkav commented 7 years ago

I am getting this only in poodll questions and not in Atto editor (poodll buttons) Seems like jquery is not recognised (although loaded)

nadavkav commented 7 years ago

This has started to happen after upgrading from M29 Poodll version to M31 Poodll 3 (paid) version.

nadavkav commented 7 years ago

Hi @justinhunt , Please see if you can give us some insight to what is causing it so maybe we could fix it ourselves.

justinhunt commented 7 years ago

Sorry Nadav, I have been back in New Zealand at a conference and visiting family, or I would have gotten onto this earlier. I will check later today and see whats up.

nadavkav commented 7 years ago

Bless you :smile:
(Wish I could be on the New Zealand MOOT or the Australian one too, one day...)

justinhunt commented 7 years ago

Nadav, I just uploaded a branch that should address this. In the end I implemented a "shim" for drawingboard.js so that it can be used with AMD. Thanks for the report.

nadavkav commented 7 years ago

Solved :smile: Bless you!