search

justinhunt / moodle-filter_poodll

The PoodLL Filter
6 stars 17 forks source link

Fixing error in paypalplayer package.json that was causing grunt errors #31

Closed rlorenzo closed 6 years ago

rlorenzo commented 6 years ago

Right now, you get this error if you try to run grunt in Moodle with this plugin installed:

`` $ grunt Running "startup" task

Running "stylelint:scss" (stylelint) task Warning: Running stylelint failed JSONError: JSON Error in /Users/rexlorenzo/Projects/moodle-docker/moodle/filter/poodll/3rdparty/paypalplayer/package.json: Unexpected token '"' at 29:5 "paypal" ^ "paypal" ^ at module.exports (/Users/rexlorenzo/Projects/moodle-docker/moodle/node_modules/parse-json/index.js:27:17) at module.exports (/Users/rexlorenzo/Projects/moodle-docker/moodle/node_modules/cosmiconfig/lib/parseJson.js:7:12) at /Users/rexlorenzo/Projects/moodle-docker/moodle/node_modules/cosmiconfig/lib/loadPackageProp.js:12:25 at :null:null Use --force to continue.

Aborted due to warnings. ``

This error was fixed on the plugin source at: https://github.com/paypal/accessible-html5-video-player/commit/a64a28e4e2757c08a3b41f1e0e271a0db2642ba2

So you can accept this patch just to fix this minor issue or upgrade to 1.04 of the paypalplayer plugin.

justinhunt commented 6 years ago

Thanks Rex. I have merged that now.