search

justinhunt / moodle-filter_poodll

The PoodLL Filter
6 stars 17 forks source link

Issue#44 : Fix unit test failures #45

Open KarlReyesCatalyst opened 1 year ago

KarlReyesCatalyst commented 1 year ago

The use statement is used to import classes or namespaces from external files. However, the external_function_parameters class seems to be part of the Moodle's external API, which is in the global namespace. Therefore, you don't need to import it with a use statement.

justinhunt commented 1 year ago

Thanks for looking at this Karl. I will have a look at this tomorrow(today) ..its just past midnight.

But I wonder if you have tested this on versions of Moodle earlier than 4.2 ?

In 4.2 they changed things for external API, but we need to use the same Poodll filter codebase to cover versions of Moodle from 3.5 all the way to 4.2. To make that work for all versions, I followed the instructions here: https://moodledev.io/docs/apis/subsystems/external/functions for "supporting multiple moodle versions", and it did work.