search

justinkhart / OverwatchChumps

3 stars 3 forks source link

Setup tiers #10

Closed justinkhart closed 7 years ago

justinkhart commented 7 years ago

GetPlayerRanksAsync() in the HomeController is currently setting the tier to an enum "Tier.Bronze" without any checks in place.

I'm thinking a constructor for the RankHistory class that calls a private method which populates the tier based on the CompetitiveRank passed in. (I'm aware Tier probably shouldn't be in the schema but I'm not too fussed at this point).

justinkhart commented 7 years ago

Open to other ideas too.

justinkhart commented 7 years ago

Went with the plan as described above, Closes #10