search

justinmayer / django-autoslug

AutoSlugField for Django. Supports (but not does not require) unidecode/pytils for transliteration. Old issue tracker is at Bitbucket: https://bitbucket.org/neithere/django-autoslug/issues
https://readthedocs.org/projects/django-autoslug/
GNU Lesser General Public License v3.0
295 stars 105 forks source link

Add type information #82

Open fabiommendes opened 1 year ago

fabiommendes commented 1 year ago

This PR implements a minimal typing support to make Autoslug work with Mypy

msopacua commented 1 year ago

Hello @justinmayer

Do you want to integrate this or prefer a stub on typeshed (which I'm preparing now for local development)?

justinmayer commented 1 year ago

@fabiommendes: Thank you for the pull request submission. My apologies for the delay in responding. Would you be so kind as to review the suggestions that @msopacua made and update your changes as appropriate?

@msopacua: Many thanks for your sponsorship, which is deeply appreciated. And thank you for your assistance with reviewing this pull request. I think integrating the type information makes sense. ✨

msopacua commented 1 year ago

@justinmayer You're very welcome. I've been using this library on and off since 2014 or so? So about time :)

neithere commented 1 year ago

It's so cool to see confirmation that the library is still useful after all these years! Thank you for keeping it alive, @justinmayer :)