Add code coverage reporting to CI flow

justinmayer / kagi

WebAuthn security keys and TOTP multi-factor authentication for Django

BSD 2-Clause "Simplified" License

92 stars 11 forks source link

Add code coverage reporting to CI flow #20

Closed justinmayer closed 5 years ago

justinmayer commented 5 years ago

We are using continuous integration to ensure future PRs don't fail our test suite, but we should also ensure our CI flow checks and reports on PR test coverage. (Refs #11 #12)

Related links:

https://circleci.com/blog/making-code-coverage-easy-to-see-with-the-codecov-orb/
https://github.com/strawberry-graphql/strawberry/commit/e2b2a813257db23845afc1f4b7f2c09236cbe15c

Natim commented 5 years ago

Right now the current CI tests fail if the coverage is not 100%.

justinmayer commented 5 years ago

Ah, I obviously didn’t realize that. What mechanism provides that exactly?

Natim commented 5 years ago

--cov-fail-under=100 https://github.com/justinmayer/kagi/blob/master/Makefile#L23-L24

Natim commented 5 years ago

Handled with #11