Closed evanottinger closed 1 year ago
Hi @evanottinger,
this migration isn't exactly missing. It appears that you are running Django with DEFAULT_AUTO_FIELD = 'django.db.models.BigAutoField'
, this is why the migrations show a change for you. I guess the correct fix in kagi (for now) would be to add:
from django.apps import AppConfig
class KagiConfig(AppConfig):
default_auto_field = 'django.db.models.AutoField'
name = 'kagi'
and then maybe migrate to BigAutoField
if wanted. What do you think @justinmayer ?
Closing this in favor of 61c1bce for now. Sorry for not merging the PR as it is currently.
Makes sense to me. Thank you!
When Kagi 0.3.0 is installed as a dependency in a Django application, the following migration is created:
This can cause problems if users extend Kagi models in their custom applications because Django will generate migrations for their custom apps dependent upon the newly generated Kagi migrations. However, since the Kagi migrations belong to a third-party package, they will not be committed to version control in the custom application's code repository. This will cause Django to throw an exception when dependent migrations are run against an application's database or even if
manage.py makemigrations
is run to attempt to create the new migrations at run-time.This PR adds the missing migration to the Kagi code repository.