Closed apollo13 closed 1 year ago
Ups, yes I missed those -- thanks! Btw, I can't commit currently (on my phone) but you could port over the workflow changes from autopub to see early if the release stuff would work with the new autopub release :)
On Wed, Jun 7, 2023, at 22:29, Justin Mayer wrote:
@.**** commented on this pull request.
I pushed a commit that adds three items to the list of changes, as well as adding some attribution so contributors will be credited in the Releases https://github.com/justinmayer/kagi/releases section, which I think is a nice touch. 😊
@apollo13 https://github.com/apollo13: What do you think?
— Reply to this email directly, view it on GitHub https://github.com/justinmayer/kagi/pull/76#pullrequestreview-1468511497, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAT5CZBA4J3LCDPTLNRYQLXKDQA5ANCNFSM6AAAAAAY5P4Q64. You are receiving this because you were mentioned.Message ID: @.***>
@apollo13: Good suggestion. I added a commit intended to port over what I think are the relevant CI configuration changes from the AutoPub repo. Would you have a look and let me know whether it looks right to you?
You can remove the twine environment variables -- that is done by the upload action below automatically. But you need to copy the adjusted if statement down there as well
On Wed, Jun 7, 2023, at 23:09, Justin Mayer wrote:
@apollo13 https://github.com/apollo13: Good suggestion. I added a commit intended to port over what I think are the relevant CI configuration changes from the AutoPub repo. Would you have a look and let me know whether it looks right to you?
— Reply to this email directly, view it on GitHub https://github.com/justinmayer/kagi/pull/76#issuecomment-1581516375, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAT5C7QVCYXN3WS44HZNJTXKDUY7ANCNFSM6AAAAAAY5P4Q64. You are receiving this because you were mentioned.Message ID: @.***>
@apollo13: Done. Good catch on both counts. How does it look now?
looks good, I mean we probably missed something but we won't know before we try? :D
Welp, I think perhaps we missed the part where the trusted publisher stuff gets set up in the non-test PyPI environment. 😓 https://github.com/justinmayer/kagi/actions/runs/5208770001/jobs/9397778566#step:7:20
Oh yes, I thought you did that by now :)
On Thu, Jun 8, 2023, at 09:58, Justin Mayer wrote:
Welp, I think perhaps we missed the part where the trusted publisher stuff gets set up in the non-test PyPI environment. 😓 https://github.com/justinmayer/kagi/actions/runs/5208770001/jobs/9397778566#step:7:20
— Reply to this email directly, view it on GitHub https://github.com/justinmayer/kagi/pull/76#issuecomment-1582088251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAT5C32FW2PEICXLF7OM4DXKGA4HANCNFSM6AAAAAAY5P4Q64. You are receiving this because you were mentioned.Message ID: @.***>
No worries. I will take a look at the relevant docs as well as how it is configured in the test PyPI environment, in order to replicate that in the production PyPI environment.
I will also take the liberty of manually publishing the Kagi 0.4.0 release to PyPI, since all the other release steps have already been automatically completed.
Kagi 0.4.0 has been published to PyPI, and the trusted publisher configuration should be all set up in the production PyPI environment for future automated package publication. Thanks again to everyone who contributed to this release! 💫
I guess we could do a release with that and then work on the new webauthn stuff.