justinmayer / virtualfish

Fish shell tool for managing Python virtual environments
MIT License
1.06k stars 100 forks source link

vf new does not support --help and --version flags #146

Closed matusf closed 4 years ago

matusf commented 5 years ago

When executing

vf new -h
vf new --help
vf new --version

new environments are created with name of the flag instead of displaying help/version information. vf takes the last argument and creates the virtualenv (here). This is probably related to #16

I'll try to send a PR in the future.

orf commented 5 years ago

I just came across this as well, quite confusing!

justinmayer commented 4 years ago

I am in the process of adding built-in argument parsing to vf new and will update this issue once it's available.

justinmayer commented 4 years ago

I have pushed a PR that implements argument parsing for vf new, among other features, which means that --help and --version should now be supported: https://github.com/justinmayer/virtualfish/pull/159

justinmayer commented 4 years ago

I added support for vf new --help and vf new --version via the above PR and https://github.com/justinmayer/virtualfish/commit/fbfda416847a4c4de3e1b72d759a37142b5a7f6a, respectively.