search

justinmayer / virtualfish

Fish shell tool for managing Python virtual environments
MIT License
1.06k stars 100 forks source link

Project compatibility with auto_activation #152

Closed hyyking closed 4 years ago

hyyking commented 5 years ago

I believe the auto_activation philosophy is to only have the venv activated when you cd to the directory. I saw that the venv would stick to you if you cd'd out of a project using the project plugin and the "workon" command

Made so thtat the project "workon" command tries to cd first and then set the venv if auto_activation didn't do it first.

Tried to respect case handling feel free to modify.

justinmayer commented 4 years ago

Hi Léo. I'm sorry for not responding earlier. I reviewed this PR several times, and each time it was too much cognitive effort to determine exactly what behaviors were changed — and more importantly, why. For example, sections of the code relating to .project files were deleted wholesale without explanation.

I'm happy to work with you to come up with a solution that improves compatibility with the Projects and Auto-Activation plugins, provided it's clear exactly what is changing and why.

hyyking commented 4 years ago

The reason I'm closing the PR (over the fact there was no update from neither of us since I first made it) is because from what understand the issue was resolved by #164 . From what I remember for the .project file is that the case was covered by the changes. I would surely have been able to explain it when I first made the PR which is also why I've closed it.