justinmayer / virtualfish

Fish shell tool for managing Python virtual environments
MIT License
1.06k stars 100 forks source link

Require minimum Fish shell version when installing #171

Closed justinmayer closed 4 years ago

justinmayer commented 4 years ago

Certain VirtualFish functionality depends on newer Fish shell features. Users on older Fish versions who don't notice the minimum version requirement may subsequently encounter errors.

For example, "&&" is not supported on older Fish versions, so this includes a commit that switches to more-verbose but more-compatible syntax. Other parts of VirtualFish still require Fish 3.1+, but this bit was causing errors any time virtualfish.fish was sourced.

This also adds a prominent minimum Fish version notice to the README. This information was already available in the Installing docs, but some folks did not see that.

Most notably, this adds a check_fish_version() function to the initial Python-based installation process that exits and notifies if the minimum Fish shell version requirement is not met.

Closes #169 #170