Fix global packages - Githubissues

justinmayer / virtualfish

Fish shell tool for managing Python virtual environments

MIT License

1.06k stars 100 forks source link

Fix global packages #173

Closed airwoodix closed 4 years ago

airwoodix commented 4 years ago

Fixes #172.

I happily replace the sed calls by a single one if someone points at a more elegant solution
toggling matches the virtualenvwrapper command but I would find it more intuitive to have to commands for setting the inclusion of system site packages. This would however be breaking.

Comments most welcome.

airwoodix commented 4 years ago

Thanks a lot for the detailed feedback! I fixed most of the points, more comments in the relevant sub-threads. The changes are broken up in several commits for convenience. I can squash everything at the end if wanted.

justinmayer commented 4 years ago

Thank you for all the changes. Other than the tab characters, everything else seems to be in order. Would you please let me know once the indentation has been sorted out?

justinmayer commented 4 years ago

Merged via b98304c. Many thanks for the global site packages enhancement. Much appreciated! 😁