search

justinmayer / virtualfish

Fish shell tool for managing Python virtual environments
MIT License
1.06k stars 100 forks source link

feat(connect): Auto-activate virtualenv if specified #200

Closed gechr closed 3 years ago

gechr commented 3 years ago

Introduce an optional <env name> argument to vf connect which auto-activates the virtualenv in question, if it exists.

gechr commented 3 years ago

@justinmayer Any interest in taking this PR or shall I close it?

justinmayer commented 3 years ago

Hi George. Thank you for the submission. The primary reason I haven't found time to fully review this pull request is the varied, unrelated changes of which it is comprised. The disparate pieces may all be valuable, but it's much more difficult to evaluate them when jumbled together in a single pull request. In an effort to get this merged as soon as possible, would you mind trimming this pull request to its bare essential functionality, submitting the other myriad changes as separate and discrete pull requests? 😅

gechr commented 3 years ago

Sure, done & squashed into a single commit.

gechr commented 3 years ago

@justinmayer All comments addressed & rebased.