justinmayer / virtualfish

Fish shell tool for managing Python virtual environments
MIT License
1.07k stars 101 forks source link

Migrate from `pkg_resources` to `importlib` #240

Closed timsutton closed 7 months ago

timsutton commented 9 months ago

Feature Request

👋 Hello, I have been working on migrating Python-based projects in homebrew-core to use explicitly-declared resources. Just wanted to flag that I noticed virtualfish depends on pkg_resources, which is removed in Python 3.12 with the removal of distutils. In the upstream Homebrew formula we'll explicitly add setuptools as a required dependency so that installation with Python 3.12 continues to work.

Some more resources:

pkg_resources to importlib_resources migration guide PEP-517

justinmayer commented 7 months ago

Many thanks for raising this topic, Tim. Thankfully, @branchvincent was kind enough to address this via the above-linked PR, which has been merged and which will automatically be released as VirtualFish 2.5.8 in a matter of minutes. ✨