search

justinmayer / virtualfish

Fish shell tool for managing Python virtual environments
MIT License
1.06k stars 100 forks source link

Workaround for #238 regression / #245 issue #247

Closed melomac closed 4 months ago

melomac commented 5 months ago

Use --version command-line option to read current fish-shell version rather than parsing assumed, configuration altered, fish command output.

melomac commented 5 months ago

Amended commit to revert Python 3.6's encoding="utf8" to better backward compatible .decode("utf-8")

melomac commented 5 months ago

Used verified email address 😬

justinmayer commented 5 months ago

Many thanks for proposing a fix, @melomac. Sorry to ask what may seem like a silly question, but is it safe to assume that you have tested this, and it works? 😊

melomac commented 5 months ago

Hi @justinmayer

I checked the regex on current fish-shell stable and fish-shell git (for the - right strip thing).

I was able to uninstall / install with python3.12 and python3.9 with no problem.

And I tried to figure out when the --version option landed in fish-shell project with no certainty, but I am confident this was well before virtualfish minimum required version.

Many thanks for virtualfish 🙏