Bug: Clear side effects related to DOM event listeners

justinmc / react-audio-player

A simple React wrapper on the HTML5 audio tag

MIT License

589 stars 104 forks source link

Closed emibcn closed 3 years ago

emibcn commented 3 years ago

Create instance methods so they remain unchanged for the removeEventListener call
Add componentWillUnmount with all the removeEventListener calls

emibcn commented 3 years ago

Fixes #104

justinmc commented 3 years ago

I just made these optional so you've got conflicts now. Would you be able to resolve them?

emibcn commented 3 years ago

I just made these optional so you've got conflicts now. Would you be able to resolve them?

Sure! It will be done during today. Thanks for your time!

emibcn commented 3 years ago

Done! You can merge now without conflicts ;)

emibcn commented 3 years ago

Fixed the types of the arguments of the event listeners by changing e: any to e: Event.

emibcn commented 3 years ago

@justinmc Are you having any trouble with this PR? I can adapt it to whatever needs you have.