justinmc / react-audio-player

A simple React wrapper on the HTML5 audio tag
MIT License
589 stars 104 forks source link

Migration to webpack5 #128

Open AyoyimikaAjibade opened 2 years ago

AyoyimikaAjibade commented 2 years ago

Please update react-audio-player to migrate to webpack5 as maintaining it in the Debian OS environment caused a bug as we try to build the package with webpack 5.65.0, as you still support of webpack4.42.1

here is a link to the bug report https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1002863

The failing build major output looks like this while building with webpack 5.65.0

   debian/rules override_dh_auto_build
make[1]: Entering directory '/home/ayoyimika/debian-js-packaging/react-audio-player/node-react-audio-player'
webpack
assets by status 0 bytes [cached] 1 asset

ERROR in main
Module not found: Error: Recursion in resolving
Stack:
  undefined: (/home/ayoyimika/debian-js-packaging/react-audio-player/node-react-audio-player) ./src/index.tsx

webpack 5.65.0 compiled with 1 error in 514 ms
make[1]: *** [debian/rules:11: override_dh_auto_build] Error 1
make[1]: Leaving directory '/home/ayoyimika/debian-js-packaging/react-audio-player/node-react-audio-player'
make: *** [debian/rules:8: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

A simple solution i proffer is migrating to webpack5 to have access to its updated features, benefits and options https://webpack.js.org/migrate/5/

Thanks and Cheers