search

justinmc / react-audio-player

A simple React wrapper on the HTML5 audio tag
MIT License
587 stars 103 forks source link

Fix deprecation warnings after upgrade to React 15.5.* #30

Closed pkosiec closed 7 years ago

pkosiec commented 7 years ago

After upgrading react to v. 15.5.*, there are two warnings related to react-audio-player:

screen shot 2017-04-23 at 14 46 17

This pull request solves #31.

justinmc commented 7 years ago

@pkosiec Thanks for fixing this and sorry for the delay! I think you left some code in from your fork that you didn't mean to, will comment it in a second. If you get that I'll go ahead and merge and release a new version.

pkosiec commented 7 years ago

@justinmc Sorry for that! I forgot to switch the branch on my fork when I was committing those things... Now it should be good to go 😉

pkosiec commented 7 years ago

Thanks! No, I don't need an immediate release, because right now I'm using a fork in my project. Those warnings are very irritating. Let me know when I can switch back to your npm package!

justinmc commented 7 years ago

@pkosiec Here's my PR removing {...this.props}: https://github.com/justinmc/react-audio-player/pull/32, and the v0.5.0 release was just published to npm. Let me know if you have any problem switching to the new version!

pkosiec commented 7 years ago

Hi @justinmc, sorry for long delay, but I totally forgot to give you a feedback! I migrated some time ago to your latest version and everything works fine. Thank you for updating your package! I'm pulling my fork as I don't need it anymore.

justinmc commented 7 years ago

@pkosiec Thanks for following up, that's great to hear!