search

justinmc / react-audio-player

A simple React wrapper on the HTML5 audio tag
MIT License
587 stars 103 forks source link

React 16.x support #42

Closed m2mathew closed 6 years ago

m2mathew commented 7 years ago

Are there plans to push the next version of this package to support React 16.x? The audio players are still working fine for me in our app, but I am getting several peer dependency warnings when doing a yarn install.

Thanks!

justinmc commented 6 years ago

I think I just got it working with 16.x! Make sure you're using the latest release right now (v0.6.4) and try it out.

I cleaned up the peer dependencies a bit and now specify React >=15. I also separated the example a little more so that it includes react-audio-player via npm like a real app. The peer dependency warnings seem to be gone based on running that example now, but let me know if that's not the case for you or if you see any room for improvements.

m2mathew commented 6 years ago

Very cool, @justinmc! I just upgraded the package and submitted my PR to our project

Yay Open Source!

image

justinmc commented 6 years ago

Awesome! Thank you and sorry this took so long.