Cross Origin Should Be Omittable

justinmc / react-audio-player

A simple React wrapper on the HTML5 audio tag

MIT License

587 stars 103 forks source link

Cross Origin Should Be Omittable #49

Closed justinmc closed 6 years ago

justinmc commented 6 years ago

Closes https://github.com/justinmc/react-audio-player/issues/48

@dmcmorris with this change, not passing the crossOrigin prop will result in an audio tag with no crossorigin attribute at all. Let me know if that fixes your use case.

justinmc commented 6 years ago

I'm going to go ahead and merge this because it seems like a solid improvement to me either way. Happy to revisit if not though.