search

justinmc / react-audio-player

A simple React wrapper on the HTML5 audio tag
MIT License
587 stars 103 forks source link

#61 move react-hot-loader to dependencies #65

Closed mahboubii closed 4 years ago

mahboubii commented 5 years ago

fixes #61

JohnHeitmann commented 5 years ago

react-hot-loader shouldn't be a full dependency. Based on some local testing, I think if @justinmc rebuilds with an updated dependency tree then babel (or whatever was doing it) will no longer add the react-hot-loader require into bundle.js; no source changes are required.

Alternately, removing react-hot-loader entirely could be appropriate. I'm not sure why it's here in the first place.

OnkelTem commented 4 years ago

Since when adding a dev module to prod deps is reckoned a fix? Sorry.

mahboubii commented 4 years ago

@OnkelTem you're right i didn't dig into the issue and source code to actually fix the problem, this is just to fix the build error.

AshotN commented 4 years ago

Is there plans to remove it fully? There hasn't been a release to NPM for a while and I just ran into this issue.