search

justinmeiners / classic-colors

Paint program for Unix. Inspired by MS Paint (Windows 95-98).
GNU General Public License v2.0
46 stars 3 forks source link

add extended motif fileselectionbox #21

Closed justinmeiners closed 2 years ago

justinmeiners commented 2 years ago
justinmeiners commented 2 years ago

Here is a first pass. Any feedback @dpeterc?

dpeterc commented 2 years ago

Wow, that was quick. It is already quite functional and offers better functionality than the old FSB. I guess you have removed the dependency on Microline, so you do not have the Detail view (list view with name, file, date). Maybe you can hide [Detail] button until it is included, so program does not crash if you click on it. Other than that - the new Extended FSB widget can have children, they are displayed on the bottom. For save dialog, you can add a drop down menu with choice of image format (PNG, JPEG, and whatever you want to support). The drop down menu on the main path is intended for recently used directories. If you want to use that, you have to store it somewhere by yourself and then fill it in on display of the dialog, same way as you did for filter. You can add icons for DirUp, Home, NewFolder, Detail, Filter... so that it will look nicer.

Unrelated to the FSB - you should display image filaname and modified status in the main window. This is should be updated on loading or saving the image.

justinmeiners commented 2 years ago

Thanks for the helpful feedback.

Maybe you can hide [Detail] button until it is included, so program does not crash if you click on it.

I contacted the author to talk about the optional microline support. He said he had some work to do to improve it, and i'm hoping he includes that in his change.

you should display image filaname and modified status in the main window.

Good idea. I'll start with file name.