search

justinmimbs / timezone-data

An Elm package containing time zone data from the IANA Time Zone Database
https://package.elm-lang.org/packages/justinmimbs/timezone-data/latest/
BSD 3-Clause "New" or "Revised" License
30 stars 5 forks source link

Add missing timezones for Norway and Sweden #6

Closed janjelinek closed 1 year ago

janjelinek commented 1 year ago

Not sure why those two countries are missing, so here is PR. Both using same EU rules according to https://www.timeanddate.com/time/zone/norway and https://www.timeanddate.com/time/change/sweden

justinmimbs commented 1 year ago

Hi Jan,

Thanks for the PR, and my apologies for the delayed response. The timezone data in this package (i.e., everything in TimeZone.elm) is built from the tz database; I don't manually edit or curate the data.

The names Europe/Oslo and Europe/Stockholm are deprecated identifiers; they are listed in the backward compatibility section of the tz database, both as links to Europe/Berlin (probably because the time Oslo and Stockholm has been the same as the time in Berlin since 1970).

There has been discussion of including support for backward-compatible zone identifiers in #4.

Can you use Europe/Berlin where you need to? Or are you getting zone identifiers from an outside source that may include older names like Europe/Oslo?

Justin

janjelinek commented 1 year ago

Hi Justin,

many thanks for your explanation, now I feel bad for wasting your time on this. I should spent more time with investigation around this topic. It's definitely not an issue for us and we can easily work with Europe/Berlin (I actually used for now Europe/Prague since data are filed manually by us).

Once again thx for your time and I'm closing this PR 👍🏼

justinmimbs commented 1 year ago

No worries at all! I'm happy to explain (and again, I'm sorry it took so long). I appreciate you jumping in with a PR, and I'm glad the workaround works for you. 👍🏼