search

justinmk / vim-dirvish

Directory viewer for Vim :zap:
Other
1.18k stars 64 forks source link

Make "." use ! with empty arglist #156

Closed elihunter173 closed 4 years ago

elihunter173 commented 4 years ago

Resolves #147

I implemented both suggestions in #147 . This could be pretty easily made into a configuration variable, but I think these are pretty agreeable changes.

justinmk commented 4 years ago

I don't think the argc() > 0 check is necessary. It's too surprising for . to have all of these conditions. Mapping the non-[count], non-visual case to plain :! makes sense, but otherwise it should not try to be so smart.

justinmk commented 4 years ago

Merged, thanks https://github.com/justinmk/vim-dirvish/commit/9c12328df924ddb875ee1e5c9fc0f939b62d6a6c