search

justinmk / vim-gtfo

Go to Terminal or File manager :point_right:
322 stars 17 forks source link

urxvt works on openSUSE 13.2, rxvt-unicode not #30

Closed Konfekt closed 9 years ago

Konfekt commented 9 years ago

Supposedly this holds for other distributions as well, thereby this ballsy pull request.

Konfekt commented 9 years ago

On a side note, is $SHELL a sensible default for GVIM? Should it not open a terminal (such as xterm, urxvt) instead ?

Here $SHELL would fail, and calling !$SHELL would start zsh in the gvim command line.

justinmk commented 9 years ago

Here $SHELL would fail, and calling !$SHELL would start zsh in the gvim command line.

I don't know what you mean. Only place $SHELL is called is as an argument to gnome-terminal.

Konfekt commented 9 years ago

Oh, ok. A misunderstandig coming from

got opens $SHELL inside gnome-terminal unless g:gtfo#terminals['unix'] is set

I overread inside gnome-terminal.

So the actual issue is that for example KDE users (Kubuntu, SUSE,...) don't have a terminal by default. How about checking for that or going for something less desktop enivronment specific such as xterm by default?

justinmk commented 9 years ago

for example KDE users (Kubuntu, SUSE,...) don't have a terminal by default

I would like to add more robust behavior for linux desktops. Discussed in https://github.com/justinmk/vim-gtfo/pull/12