Closed searleser97 closed 1 year ago
Thanks for working on this! Is it totally necessary, though? About half a year ago, vim-sneak worked as-is in vscode-neovim, and then something broke - maybe a fix, rather than a completely different approach, would be better? What about adding support for the conceal
property?
Imo, the easymotion text-decoration workaround isn't ideal either, it would be best to add extmark support to vscode-neovim and then use hop.nvim as-is.
Besides the above question, https://github.com/justinmk/vim-sneak/pull/303 may also have helped here.
Actually, Now there is no reason to keep using vim-sneak
sine we now have leap
plugin which works with VSCode and does better job than vim-sneak
.
Wrong. vim-sneak supports vim 7.3.
Updated PR from: https://github.com/justinmk/vim-sneak/pull/284, just for reference
Context
vscode-neovim
does not supportconceal
properly when highlighting for now, therefore, when usinglet g:sneak#label = 1
the labels were not shown as expected, instead, the first character of the match is shown always.vscode-neovim
supportstext decorations
to be shown on top of existing text with the option"vscode-neovim.textDecorationsAtTop": true
in vscode'ssettings.json
easymotion
plugin had a similar issue that was solved usingtextDecorations
for vscode. See https://github.com/asvetliakov/vscode-neovim#vim-easymotion and commit adding text decorationshttps://user-images.githubusercontent.com/5056411/136433077-53bd524c-09e1-49fd-ba71-10d9e5ffbda6.mp4
note 1: all the labels have the same key on them note 2: you can see the key strokes on the status line at the bottom
What does this PR do?
It adds support for
vscode-neovim
by addingtext-decorations
just when the user is in vscodeEvidence
https://user-images.githubusercontent.com/5056411/136434014-5f5ad353-11f3-4c18-b4a5-e1008d4f63de.mp4