justinmoon / junction

UI For Using Hardware Wallets With Bitcoin Core
MIT License
60 stars 13 forks source link

Implement an error handler screen with a report button #37

Closed wbobeirne closed 5 years ago

wbobeirne commented 5 years ago

What This Does

Implements componentDidCatch on App, as well as backup handlers for the global error and unhandledrejection events. Whenever one of these hits, we render an ErrorScreen component which displays the error, has a link to reload the app, and a link to GitHub with an issue pre-filled out.

There are still some improvements that could be made:

Steps to Test

Screenshots

Error screen

Screen Shot 2019-10-01 at 12 46 29 AM

Pre-filled GH issue

Screen Shot 2019-10-01 at 12 54 26 AM

I truncated and showed preview instead of editor, but the user would be able to add notes if they wished and the full errors would be there.

justinmoon commented 5 years ago

Dammit I didn't see this. Sorry about that. I'll try to review today.