search

justinpotts / terml.io

Code for https://terml.io
0 stars 0 forks source link

Let users click possible choices to replace disambiguation errors #46

Open jeffw16 opened 8 years ago

jeffw16 commented 8 years ago

Issue by jeffw16 Friday Aug 21, 2015 at 23:04 GMT Originally opened as https://github.com/justinpotts/terml.io-retired/issues/37

Currently, when a DisambiguationError is caught, a list of possible alternatives is presented to the user. However, the user must then manually find in their Terml.io list where that ambiguous term is, then manually replace the text.

Proposal

  1. Link each of the possible choices.
  2. Have a JavaScript onclick method ready to call a JavaScript function (jQuery?) that replaces the respective ambiguous term with the selected replacement term.

Current: termlio_disambig_fix_1

Proposed: termlio_disambig_fix_2

Implementation

jeffw16 commented 8 years ago

Comment by justinpotts Wednesday Oct 28, 2015 at 18:31 GMT

I gave this some thought today and here's what I'm thinking...

A lot of users have complained that if there a lot of ambiguous terms, they have to keep clicking create until its clean, which is a hassle, especially on mobile. What I think I'd like to do is define all of the ambiguous terms with their combos, then on the set list show something like this:

War of 1812: Definition goes here
American Revolution: Definition goes here
Treaty (See multiple definitions ->) *expandable*
    Treaty of Paris: Definition goes here
    Treaty of Ghent: Definition goes here
    And so on...

I think it may take a little bit more time to define, but I think in the end, it will benefit usability and user workflow. Thoughts?

In the future, users may even be able to select the correct definition and save the set so they don't have to read through the suggested items afterwards.

jeffw16 commented 8 years ago

Comment by jeffw16 Wednesday Oct 28, 2015 at 18:41 GMT

Yes, I like that idea. I do think it is worth it. And once I find the DB bug, report it, fix it, and run these new disambig fixes, we can use the existing code additions and implement this as well.