search

justinribeiro / lite-youtube

The fastest little YouTube web component on this side of the internet. The shadow dom web component version of Paul's lite-youtube-embed.
https://www.npmjs.com/package/@justinribeiro/lite-youtube
MIT License
836 stars 63 forks source link

Document fallback with example styles #73

Closed mrwweb closed 1 year ago

mrwweb commented 1 year ago

As discussed on #71, there's not much the component can do itself to provide a fallback, but it's very valuable to document how the fallback works for people less familiar with web components.

This adds a prominent example and educational info that will hopefully encourage people to provide a fallback for the numerous instances when it might be needed. It includes some opinionated example styles which specifically call out using aspect-ratio to match the normal dimensions of a YouTube embed.

Adding this documentation feels like enough to satisfy #71 in my opinion, but I'd like to hear @simevidas weigh in on that too.

Additional minor change: remove whitespace at start of lines in playlist example that no other example code has.

justinribeiro commented 1 year ago

Cheers for the PR! :partying_face: