justinross / foundry-bitd-alternate-sheets

MIT License
5 stars 11 forks source link

Descriptions are in {{}} instead of {{{}}} #72

Open Zylofan opened 1 year ago

Zylofan commented 1 year ago

Most if not all the descriptions from the playbooks to the items are in double { instead of triple. This is a problem as most texts in foundry are forced into

tags. Without the third {. the tags are treated as text and so new content not from the system like additional playbooks will have the tags show up in their descriptions.

This doesn't effect the system descriptions because foundry stores them differently. Though they can suffer the same fate if the compendium is unlocked and they are opened.

justinross commented 1 year ago

Thanks for the report.

Are there specific descriptions you're seeing issue with?

Mostly, I don't want text data output as HTML, because frankly I don't trust users to not (intentionally or otherwise) put weird stuff in that will mess up layouts. :)

That is to say, if there are places you're seeing issues, I can make sure html tags are getting stripped out before it's rendered (pretty sure I'm already doing so in one or two places), but I'm probably not going to change much (if anything) over to outputting HTML.

Zylofan commented 1 year ago

Thats also a valid solution. Iv seen the proble. In the playback description, and all of the on hover tooltips on the playbook sheet; and in the tooltips of the pop-ups for selecting abilities and items.

On Wed, Feb 22, 2023, 10:05 AM justinross @.***> wrote:

Thanks for the report.

Are there specific descriptions you're seeing issue with?

Mostly, I don't want text data output as HTML, because frankly I don't trust users to not (intentionally or otherwise) put weird stuff in that will mess up layouts. :)

That is to say, if there are places you're seeing issues, I can make sure html tags are getting stripped out before it's rendered (pretty sure I'm already doing so in one or two places), but I'm probably not going to change much (if anything) over to outputting HTML.

— Reply to this email directly, view it on GitHub https://github.com/justinross/foundry-bitd-alternate-sheets/issues/72#issuecomment-1440435736, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATFG364FJMCSGLGKSHLPOGLWYZBMBANCNFSM6AAAAAAVD5IE3A . You are receiving this because you authored the thread.Message ID: @.***>

justinross commented 1 year ago

Any interest in testing a fix? You'll need to uninstall (I think) the module and reinstall it with this manifest url: https://github.com/justinross/foundry-bitd-alternate-sheets/releases/download/1.04b/module.json

No major changes or changes to data structure, so it should be pretty safe, but I'd still back up your world, just in case.

Zylofan commented 1 year ago

Yup that all seems to be working now, thanks!

On Wed, Feb 22, 2023 at 10:40 AM justinross @.***> wrote:

Any interest in testing a fix? You'll need to uninstall (I think) the module and reinstall it with this manifest url: https://github.com/justinross/foundry-bitd-alternate-sheets/releases/download/1.04b/module.json

No major changes or changes to data structure, so it should be pretty safe, but I'd still back up your world, just in case.

— Reply to this email directly, view it on GitHub https://github.com/justinross/foundry-bitd-alternate-sheets/issues/72#issuecomment-1440490010, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATFG36Y33D3XFCGAYCC5NRDWYZFRRANCNFSM6AAAAAAVD5IE3A . You are receiving this because you authored the thread.Message ID: @.***>

justinross commented 1 year ago

Cool. I’ll pull those into my next release. I’ll be sure to reference the issue when I release the update so you get a notification and can switch back to the Foundry Package Manager version.

Thanks! On Feb 22, 2023 at 11:16 AM -0800, Zylofan @.***>, wrote:

Yup that all seems to be working now, thanks!

On Wed, Feb 22, 2023 at 10:40 AM justinross @.***> wrote:

Any interest in testing a fix? You'll need to uninstall (I think) the module and reinstall it with this manifest url: https://github.com/justinross/foundry-bitd-alternate-sheets/releases/download/1.04b/module.json

No major changes or changes to data structure, so it should be pretty safe, but I'd still back up your world, just in case.

— Reply to this email directly, view it on GitHub https://github.com/justinross/foundry-bitd-alternate-sheets/issues/72#issuecomment-1440490010, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATFG36Y33D3XFCGAYCC5NRDWYZFRRANCNFSM6AAAAAAVD5IE3A . You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>