justinsalamon / scaper

A library for soundscape synthesis and augmentation
BSD 3-Clause "New" or "Revised" License
384 stars 56 forks source link

Close tmpfiles on error #49

Closed beasteers closed 5 years ago

beasteers commented 5 years ago

Close tmpfiles if an exception is raised before exiting _close_tmp_files

This is in reference to #50


This change is Reviewable

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8cc985aed49c77f9a7dddc71a504a92f58d610ff on bensteers:close_tmpfiles_on_error into 18e679f4ae4f9b0fa4e646eabbde363f81d06f48 on justinsalamon:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 7dbcea913bbbdce93f45ed05ff6b8e2bd1f8eb0d on bensteers:close_tmpfiles_on_error into 3c83bba96c146025119516b4e1a6f3ef7ff5bfad on justinsalamon:master.

justinsalamon commented 5 years ago

Please merge upstream changes from my master into your brach so that this PR only includes commits relevant to this update, once that's done I'l review, thanks!

beasteers commented 5 years ago

kk all set.

justinsalamon commented 5 years ago

merged.