justinsb / jetcd

Java binding for etcd
Apache License 2.0
137 stars 55 forks source link

jetcd leaves behind non-daemon threads belonging to http client #8

Open timboudreau opened 10 years ago

timboudreau commented 10 years ago

Great project, but it's a little annoying that it leaves behind non-daemon threads that can keep a program from exiting or keep resources tied up. In particular, if you use a framework which allows for cleanly shutting down everything without killing the VM, anything that leaves behind stuff like this is problematic.

I've patched jetcd to allow the HTTP client to be passed in, to avoid that situation.

(sorry about also including the pom.xml - I can't find a way to exclude that commit from my pull request)