justinschuldt / syr-marketplace

Open-source marketplace front-end powered by Stelace API including search, platform automation, user management, transactions, real-time messaging, ratings and much more :zap:
https://marketplace.demo.stelace.com
MIT License
1 stars 3 forks source link

Cannot enter exact address in profile. #6

Open thihamin opened 3 years ago

thihamin commented 3 years ago

The autofill only resolves to city level address for some addresses.

Screen Shot 2021-03-18 at 10 12 31 PM

When I searched for "33 Jennings Ct, San Francisco" on my profile, the 'house_number' doesn't show up. I am guessing that it might be an issue with openstreetmap search functionality. When I searched "175 5th Ave, new york", the house_number showed up in address (when looking at Network response in Chrome browser)

Stelace uses 'Maptiler'. The api call to mapquest's openstreetmap api is here. https://github.com/justinschuldt/syr-marketplace/blob/dev/src/utils/places.js#L34

TODO:

thihamin commented 3 years ago

Here is what the api currently returns

0: {place_id: "117708255",…}
address: {road: "West 34th Street", neighbourhood: "Koreatown", city: "New York City",…}
city: "New York City"
country: "United States of America"
country_code: "us"
county: "New York County"
neighbourhood: "Koreatown"
postcode: "10001"
road: "West 34th Street"
state: "New York"

boundingbox: ["40.7510002", "40.7521959", "-73.9934596", "-73.990617"]
class: "highway"
display_name: "West 34th Street, Koreatown, Manhattan Community Board 5, New York County, New York City, New York, 10001, United States of America"
importance: 0.635
lat: "40.751874"
licence: "Data © OpenStreetMap contributors, ODbL 1.0. https://www.openstreetmap.org/copyright"
lon: "-73.9926944"
osm_id: "195743208"
osm_type: "way"
place_id: "117708255"
type: "primary"
thihamin commented 3 years ago

"house_number" showed up when searching "175 5th ave, new york"

Screen Shot 2021-04-04 at 1 06 50 PM
justinschuldt commented 3 years ago

It seems this should be titled "full address does not show in profile" as it is being captured and geocoded to the correct lat/lon.

I'm not sure we want to show people's full address on the profile. Maybe we could show it to them, then have the public facing profile keep the current behavior.

I am closing this since it's not obvious that the existing behavior should change. We can circle back later if we want.

thihamin commented 3 years ago

@justinschuldt this issue is not about showing full address in profile. Currently we cannot get the exact address of some addresses. For example, "33 Jennings Ct, San Francisco" was my previous address in SF. If I type that in, the result from openstreetmap api doesn't return that address. So we cannot geocode that address. We will need the ability to know the house number to be able to pickup food at a location.

I also verified that the issue is not fixed on d4d branch.

Screen Shot 2021-04-17 at 11 59 47 AM
thihamin commented 3 years ago

updated the description of the ticket.