Not fully compatible with netstandard20

justinstenning / SharedMemory

C# shared memory classes for sharing data between processes (Array, Buffer and Circular Buffer)

https://www.nuget.org/packages/SharedMemory

Other

569 stars 119 forks source link

Not fully compatible with netstandard20 #33

Closed ugumba closed 5 years ago

ugumba commented 6 years ago

Hi, I'm referencing the package from a netstandard2.0 project, and VS displays this warning:

warning NU1701: Package 'SharedMemory 2.1.0' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.

Is this expected? Are there any risks in ignoring this warning?

Edit: I guess the library projects should target netstandard2.0 instead of netcoreapp2.0.

Brgds, Robert

justinstenning commented 5 years ago

The reason it originally targeted netcoreapp2.0 was because it uses DynamicMethod from System.Reflection.Emit which was not available.

Will send new PR that includes the new dependency in NuGet also.

ugumba commented 5 years ago

Ah, makes sense. Thanks!