justinstenning / SharedMemory

C# shared memory classes for sharing data between processes (Array, Buffer and Circular Buffer)

https://www.nuget.org/packages/SharedMemory

Other

566 stars 118 forks source link

avoid starting a Task for every RPC message #63

Closed shuebner closed 2 years ago

shuebner commented 2 years ago

addresses #62 and maybe even #52, but mostly I personally want cancellation.

This is not polished or anything.

It seems to not break anything according to the tests, has no breaking API changes and does two things:

enable cancellation on RPC (TODO: add unit tests for cancellation)
avoids potential threadpool starvation by not creating a Task for each RPC message anymore

justinstenning commented 2 years ago

@shuebner I've re-targeted this to the develop branch. Could you please adjust your implementation for this. Feel free to replace the existing attempts to change the Task creation.

justinstenning commented 2 years ago

@shuebner heads-up I'm writing some benchmarks so we can compare implementations.

shuebner commented 2 years ago

@spazzarama The develop branch already got rid of the WaitHandle, so my changes will look very different. I will close this PR and create a new one.

Here it is:

justinstenning / SharedMemory

avoid starting a Task for every RPC message #63

64