Added missing feature to offset into IAssemblyCode

justinstenning / SharpDisasm

SharpDisasm - x86 / x86-64 disassembler for .NET

https://www.nuget.org/packages/SharpDisasm

Other

214 stars 39 forks source link

Added missing feature to offset into IAssemblyCode #4

Closed tgiphil closed 7 years ago

tgiphil commented 8 years ago

Removed some unused code
Set some member fields to internal
Added unit test for offset

tgiphil commented 8 years ago

Any chance to incorporate my patches?

justinstenning commented 8 years ago

Completely missed this one, sorry

justinstenning commented 8 years ago

@tgiphil please submit a pull against the Develop branch and I will merge it in. I'm not 100% sure I'm happy with making the original udis properties internal only as there may be uses for having them available - I'll have a think, but submit the pull request as is for now.

tgiphil commented 8 years ago

Done.

I can revert out the changes related to making the udis properties. However, it just made sense to me to keep the low level, internal structures & classes as internal. And, if necessary, to build out a proper interfaces when that information needs to exposed.

justinstenning commented 7 years ago

Pull request #5 instead