search

justinsunho / leesreview.com

BSD Zero Clause License
0 stars 0 forks source link

Changed neutral-6 to neutral-8 #33

Closed christineyoo closed 3 years ago

christineyoo commented 3 years ago

Fixes issue #9

justinsunho commented 3 years ago

This one does fix the navbar phone and email issue, but it's a little too specific. It actually changes all <SmallCaps /> color styles. This can be seen on the sections above the headings, etc.

christineyoo commented 3 years ago

Since this would change all <SmallCaps /> color styles, does a CSS selector that only targets the phone and email info on top already exist? Or is it necessary to create such a selector? I hope my question makes sense.

justinsunho commented 3 years ago

so, you would have to find where that specific instance of <SmallCaps /> exists, and see how you would update the color at that specific instance. You also have to make sure that the component that handles those styles is not being used elsewhere.

If you do a quick search in the repo for 'phone' or 'email' it might lead you to it. Just be aware that the component that has that is being used in the footer and on /contact page as well (with different styles)

justinsunho commented 3 years ago

@christineyoo overall, great job! I kept the new code you created, but just moved it around to keep things a bit organized. Hopefully the comments can be helpful!