justintadlock / breadcrumb-trail

Official home of the Breadcrumb Trail plugin for WordPress.
GNU General Public License v2.0
136 stars 61 forks source link

(Suggestion) Avoid quotes issue with search results label #24

Closed mikedance closed 7 years ago

mikedance commented 8 years ago

Currently the default search label is:

Search results for “%s”

So when the user searches for something in quotes, the output looks like this:

Search results for ""sample search query""

This is basically expected from a developer POV, but it looks a lot like a bug (or at least a typo) to the end user.

To avoid, I usually filter the label to:

Search results for: <span>%s</span>

The colon does the same job the quotes used to, and the extra <span> allows a developer to optionally bold or whatnot.

justintadlock commented 8 years ago

I actually like this suggestion. If I decide to change it here, I'll need to change it in my framework too just for consistency. It's a good idea though.