Open colin-marshall opened 7 years ago
Perhaps list_attr
and item_attr
(for controlling all element attributes) might be even better. I can pull this from already existing code I have in other projects.
Yes! That would make it even more flexible/customizable.
I actually did a fork adding classes but thought this project was abandoned..
https://github.com/Log1x/breadcrumb-trail
Want me to redo my changes for dev-master and submit a proper PR? I also added Composer support and bumped the after_theme_setup
for current_theme_supports
up in priority as it wasn't firing in Sage 9's default setup.php
Please add to
// Open the unordered list. <%s class="trail-items" itemscope itemtype="http://schema.org/BreadcrumbList">
the ability to specify your own class list_class
something like that
<ul class="trail-items breadcrumbs" itemscope itemtype="http://schema.org/BreadcrumbList">
Right now we are stuck with having
class="trail-items"
andclass="trail-item
for<ul>
and<li>
items respectively. It would be great if we had the option to use custom classes for the<ul>
and<li>
items.I can put in a pull request if you are interested.